-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] 0017 Remove log.original stage 2 #1347
Conversation
Thanks, @djptek, for continuing to advance this. I came across a use of |
@elastic/security-external-integrations This is a proposal to deprecate |
@ebeahan yep, there are a few more
I would expect this could be resolved in Kibana through an alias, however that won't work in Beats and there may be further impact where I think that's less likely in Logstash, by the timelines but I'll look anyway & I will definitely need to do some digging in I will review this thoroughly update the RFC |
I ran Some of these were actually references to [Filebeat] [SIEM] Fileset for Cisco FTD logs #13286 where this change had already been implemented
The majority of references are mappings e.g. `"msg": {to:[{field: "log.original", setter: fld_set}]}`` Full list of remaining references was:
|
Likewise Kibana has plenty of references to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
I have a few minor notes, but overall I think looks great. Thanks for being thorough and connecting with the other teams/stakeholders mentioned here, @djptek!
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
make test
? Ymake
and committed those changes? n/aProgress RFC 0017 Remove log.original to stage 2