Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump github.com/elastic/mock-es #5128

Merged
merged 2 commits into from
Jul 12, 2024
Merged

build: bump github.com/elastic/mock-es #5128

merged 2 commits into from
Jul 12, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

bump github.com/elastic/mock-es

Why is it important?

Split from #5120
Remove hard dependency on gofrs/uuid and unblock #5120

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@kruskall kruskall requested a review from a team as a code owner July 12, 2024 16:26
@kruskall kruskall requested review from blakerouse and pchila July 12, 2024 16:26
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 12, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@kruskall kruskall mentioned this pull request Jul 12, 2024
Merged
7 tasks
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jul 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@kruskall kruskall merged commit 4331822 into elastic:main Jul 12, 2024
13 of 14 checks passed
@kruskall kruskall deleted the bump/mock-es branch July 12, 2024 21:24
@michalpristas michalpristas added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-skip labels Aug 5, 2024
mergify bot pushed a commit that referenced this pull request Aug 5, 2024
@kruskall @mergify
build: bump github.com/elastic/mock-es (#5128)
ea62a29 
* build: bump github.com/elastic/mock-es

* build: regenerate notice file

(cherry picked from commit 4331822)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Aug 5, 2024
Merged
7 tasks
michalpristas added a commit that referenced this pull request Aug 5, 2024
@mergify @kruskall @michalpristas
[8.15](backport #5128) build: bump github.com/elastic/mock-es (#5255)
1107d5f 
* build: bump github.com/elastic/mock-es (#5128)

* build: bump github.com/elastic/mock-es

* build: regenerate notice file

(cherry picked from commit 4331822)

# Conflicts:
#	go.sum

* conflicts resolved

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@kruskall kruskall

Labels
backport-8.15 Automated backport to the 8.15 branch with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kruskall @elasticmachine @ycombinator @pierrehilbert @michalpristas