Enable _dev/deploy for data streams #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
I think this PR depends on elastic/package-spec#111? I will review this PR once elastic/package-spec#111 is reviewed and merged. |
2 tasks
|
I updated the package-spec in this branch. |
ycombinator
reviewed
Jan 26, 2021
| logger.Errorf("can't find _dev/deploy directory") | ||
| return nil, ErrNotFound | ||
| } | ||
| fmt.Println(devDeployPath) |
ycombinator
reviewed
Jan 26, 2021
| if err == nil { | ||
| return packageDevDeployPath, nil | ||
| } else if !os.IsNotExist(err) { | ||
| return "", errors.Wrapf(err, "stat failed (path: %s)", packageDevDeployPath) |
There was a problem hiding this comment.
Both the errors (the one and the one above for the data stream) are very similar. Can you differentiate them a bit by saying that one failed for the data stream and one for the package?
There was a problem hiding this comment.
The path argument would be different, but I extended the error message to include also some context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #89
This PR enables custom
_dev/deployfor data stream. It will be used by the future AWS service deployer.