Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Remove SYS TABLE TYPES command #37409

Closed
costin opened this issue Jan 14, 2019 · 1 comment
Closed

SQL: Remove SYS TABLE TYPES command #37409

costin opened this issue Jan 14, 2019 · 1 comment
Labels
:Analytics/SQL SQL querying >enhancement v6.7.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Jan 14, 2019

Command SYS TABLE TYPES was introduced to support both ODBC and JDBC in discovering the types of tables ES SQL supports.
In practice however only JDBC uses this command directly while ODBC relies on SYS TABLES - as such, it makes sense to consolidate them especially since SYS TABLES allows for many other params.

In the same vein, SYS CATALOGS might be removed since it's not that used and can be replaced with SELECT DATABASE() until full catalog behavior is in place.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

costin added a commit to costin/elasticsearch that referenced this issue Jan 15, 2019
@costin
SQL: Remove slightly used meta commands
9fc7669 
Remove SYS CATALOGS and SYS TABLE TYPES as they are a subset of SYS
TABLES (and thus somewhat redundant) and used only by JDBC.

Close elastic#37409
@costin costin mentioned this issue Jan 15, 2019
Merged
costin added a commit that referenced this issue Jan 16, 2019
@costin
SQL: Remove slightly used meta commands (#37506)
023bb2f 
Remove SYS CATALOGS and SYS TABLE TYPES as they are a subset of SYS
TABLES (and thus somewhat redundant) and used only by JDBC.

Close #37409
costin added a commit that referenced this issue Jan 16, 2019
@costin
SQL: Remove slightly used meta commands (#37506)
282ce36 
Remove SYS CATALOGS and SYS TABLE TYPES as they are a subset of SYS
TABLES (and thus somewhat redundant) and used only by JDBC.

Close #37409

(cherry picked from commit 023bb2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @colings86 @elasticmachine