Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to the max file descriptors number #41441

Closed
wants to merge 1 commit into from
Closed

Conversation

robb3rt
Copy link

@robb3rt robb3rt commented Apr 23, 2019

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@colings86 colings86 added :Core/Infra/Core Core issues without another label >docs General docs changes labels Apr 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member

rjernst commented May 6, 2019

Thanks for the PR @robb3rt. Can you please explain why you believe this documentation needs updating? The docs match the bootstrap check we have in place for max file descriptors.

@robb3rt
Copy link
Author

robb3rt commented May 7, 2019

@rjernst the max file descriptors should be 65536 or higher or bootstrap checks will fail. Right now the commands we list to set the max file descriptors set it to 65535 instead.

Also quoting our documentation:

Make sure to increase the limit on the number of open files descriptors for
the user running Elasticsearch to 65,536 or higher.

@rjernst
Copy link
Member

rjernst commented May 19, 2019

Which version of Elasticsearch are you using? This was changed to 65535 in #37537, which merged to 6.7 and 7.0. The documentation matches the check.

@rjernst
Copy link
Member

rjernst commented May 19, 2019

I think the discrepancy is in the line that you quoted in your last comment, which should be changed to 65535. It was not caught in #37537 because it contains a comma.

@javanna
Copy link
Member

javanna commented Jul 15, 2019

hi @robb3rt do you plan on updating your PR based on the comments you received above?

@danielmitterdorfer
Copy link
Member

I'm closing this PR meanwhile due to lack of feedback. If there is interest to continue with this PR, please reopen. Thank you. :)

@colings86 colings86 deleted the robb3rt-patch-1 branch May 27, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes feedback_needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants