Exposes source_url and issues_url of cookbook #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ge1st Looks clean to me, I like it. Go ahead and add minified css. Thank you for your help. 👍 |
|
It has been a while since I've dug around in here, but since everything is a static file, I think you would actually need to commit the minified css in order for any users to actually see the changes. There are tasks in the Rakefile to |
|
Created new issue about the process to minify CSS and JS files. |
|
Going to merge this without Min CSS b/c next PR will remove need to Min by hand. Thank you @ge1st |
tapickell
added a commit
that referenced
this pull request
Dec 21, 2015
Exposes source_url and issues_url of cookbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
So Ridley is setting these as empty strings, thus the ugly
emptycalls.The cookbook detail now looks like ^^. Design guidance appreciated.
Anything I miss? Also didn't commit the minified css. Want me to?