Process and strip markdown/HTML in OPF meta tags #583
+22
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @jaycolmvar in #560, this strips markdown/HTML from meta tags in the OPF file. That markup may be present
in
meta.yml
since we do allow it, so that it's possible to include, say, italics in a title or project name.I haven't tested this very thoroughly – only on one simple epub so far.
@LouiseSteward @bertuss @jaycolmvar can you think of any cases or reasons this might be a bad idea? Essentially, we need plain text that is valid XML in the
package.opf
file we build with theepub-package
include.