Avoid initialising multiple times #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were setting the listener on the bookmarks icon multiple times. This is a fix.
|
✔️ Deploy Preview for electric-book ready! 🔨 Explore the source changes: ad154b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/electric-book/deploys/61e7235741a1d50007486d7f 😎 Browse the preview: https://deploy-preview-625--electric-book.netlify.app/samples/text/01-10-questions |
arthurattwell
added a commit
that referenced
this pull request
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the listener on the bookmarks icon multiple times by not exiting the mutationObserver loop when calling
ebBookmarksInit(). This resolves that problem.I noticed it on the EBT's plain-text samples chapter, where the bookmarks modal was opening and closing an odd number of extra times, meaning it appeared to not open at all.
@bertuss I seem to remember you spotted this or something like it when working on bookmark syncing recently? You may have fixed it another way in your work.