-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use new Issue Template types in templates #44224
Conversation
Tentatively LGTM, but want to further consider our existing automation to ensure none of it relies on those labels and will need to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of this change, but am marking as "comment" for now so that it doesn't get merged accidentally before @dsanders11 is done checking the automation 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what I've found for our automation using these labels. It looks like the automation usage is isolated to this repo (I did an org-wide search), which is nice.
We exempt feature request issues from the stale bot - I don't see a migration path here if we drop that label since actions/stale
does not yet have the concept of issue types.
electron/.github/workflows/stale.yml
Line 30 in 36b7cf3
exempt-issue-labels: "discussion,security \U0001F512,enhancement :sparkles:,status/confirmed,stale-exempt" |
The issue triage automation checks for bug issues by the label. I'm not seeing the issue type exposed in the API (example issue), so I don't think there's a migration path here either without the label.
if: ${{ contains(github.event.issue.labels.*.name, 'bug :beetle:') }} |
With these in mind, I think we should continue to use the labels until GitHub better supports issue types in their API and stale action. Let's add back the lines with the labels and we'll make that leap when we have the support we need. The other changes seem fine.
No Release Notes |
* build: use new Issue Template types in templates * build: restore existing labels for now
* build: use new Issue Template types in templates * build: restore existing labels for now
* build: use new Issue Template types in templates * build: restore existing labels for now
Description of Change
Use new Issue Types in our templates for improved sorting and categorization.
Release Notes
Notes: none