Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Temporarily build with intermediate requirements #1511

Merged
merged 1 commit into from
Dec 1, 2023
Merged

build: Temporarily build with intermediate requirements #1511

merged 1 commit into from
Dec 1, 2023

Conversation

felixrieseberg
Copy link
Member

This enables us to build with intermediate designated requirements to move the codesigning certificate on macOS from me to OpenJS.

Major downside: This will break CI as written, since CI currently only has the OpenJS certificate.

@felixrieseberg felixrieseberg requested review from codebytere and a team as code owners November 30, 2023 17:40
@coveralls
Copy link

Coverage Status

coverage: 87.191%. remained the same
when pulling c9e3381 on felixr-intermediate-build
into 062882d on main.

@dsanders11 dsanders11 marked this pull request as draft November 30, 2023 23:14
@felixrieseberg felixrieseberg marked this pull request as ready for review December 1, 2023 23:51
@felixrieseberg felixrieseberg merged commit 729f60d into main Dec 1, 2023
@felixrieseberg felixrieseberg deleted the felixr-intermediate-build branch December 1, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixrieseberg @coveralls @dsanders11