Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload window button not working #1561

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

gaspardruan
Copy link
Contributor

When clicking the reload window button, nothing happened. The console reported the error
image
errors occur when reload window button is clicked

I just changed one line and it works fine.

- onClick={window.ElectronFiddle.reloadWindows}
+ onClick={() => window.ElectronFiddle.reloadWindows()}

@gaspardruan gaspardruan requested review from codebytere and a team as code owners March 16, 2024 09:13
@coveralls
Copy link

Coverage Status

coverage: 87.245% (-0.02%) from 87.262%
when pulling e1125bd on gaspardruan:fix-reload-button
into d577648 on electron:main.

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsanders11 dsanders11 merged commit 23eb6a7 into electron:main Mar 16, 2024
10 checks passed
@gaspardruan gaspardruan deleted the fix-reload-button branch March 17, 2024 02:27
@gaspardruan gaspardruan restored the fix-reload-button branch March 18, 2024 07:57
@gaspardruan gaspardruan deleted the fix-reload-button branch March 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants