Forward the ref in the Button component #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
requested review from
andybalaam and
SimonBrandner
and removed request for
a team
Deploying with
|
| Latest commit: |
c83737b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://daed3ea9.compound-web.pages.dev |
| Branch Preview URL: | https://quenting-button-forward-ref.compound-web.pages.dev |
sandhose
force-pushed
the
quenting/button-forward-ref
branch
from
a1200a3 to
c83737b
Compare
SimonBrandner
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue for MAS, where we need the ref to autofocus some buttons.
I had to do weird type assertions because of the generic
asproperty, but the type looks correct, and the ref is properly forwarded.