Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "device" field from get /pushrules response model. #7918

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 9, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove unused field, see matrix-org/synapse#12482

It's worth noting that if removed from the server response, the existing code will not crash since a default value was assign to device.

Motivation and context

Be spec compliant.

Screenshots / GIFs

NA

Tests

Code compiles.

Tested devices

NA

Checklist

@ElementBot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 6eece5b

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty bmarty requested review from a team and Florian14 and removed request for a team January 10, 2023 09:16
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 4f829f1 into develop Jan 10, 2023
@bmarty bmarty deleted the feature/bma/pushRuleModel branch January 10, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants