Add config param to disable e2e for signalling #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Šimon Brandner <[email protected]>
| // them. | ||
| const params = new URLSearchParams(window.location.search); | ||
| // disable e2e only if enableE2e=false is given | ||
| const enableE2e = params.get("enableE2e") !== "false"; |
There was a problem hiding this comment.
What happens if someone tries to join an encrypted call without encryption?
There was a problem hiding this comment.
There aren't really 'encrypted calls' as such: clients with this flag set to false will still decrypt any encrypted signalling they receive, so (I think) it should all still work. However, this is very deliberately hidden in an undocumented URL param, so anyone playing with it gets to keep both pieces if it breaks. :)
SimonBrandner
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliberately not making it an option on the room since then we'd have to worry about server doing downgrade attacks.
Requires matrix-org/matrix-js-sdk#2492