Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read-receipts shifting backwards in the timeline #21016

Closed
anoadragon453 opened this issue Feb 9, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2174
Closed

Read-receipts shifting backwards in the timeline #21016

anoadragon453 opened this issue Feb 9, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2174
Assignees
@t3chguy
Labels
A-Read-Receipts S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

A few times now, I've observed a user's read receipt animating back up the timeline(!) to the previous message after the user in question sends a message of their own:

Case 1:
image

Case 2:
image

Note the read receipt markers on the right. In both instances, Erik's read receipt should at least be at his latest message.

  • User A sends a message (message 1)
  • User A's read receipt is set to message 1
  • User B sends a message (message 2)
  • User B's read receipt is set to message 2
  • User A's read receipt is set to message 2 after they read it
  • User B's read receipt incorrectly animates back up to message 1. It should not have moved.

Outcome

What did you expect?

Read receipts not to ever go backwards

What happened instead?

Read receipts walk backwards up the timeline. This is weird.

Operating system

Arch Linux

Application version

Element Nightly version: 2022020802, Olm version: 3.2.8

How did you install the app?

https://aur.archlinux.org/packages/element-desktop-nightly-bin/

Homeserver

No response

Will you send logs?

Yes
@SimonBrandner
Copy link
Contributor

This seems like something that should have been fixed by matrix-org/matrix-js-sdk#2160 though if my math is right, your version of Element should have that fix :/

@SimonBrandner SimonBrandner added A-Read-Receipts S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression labels Feb 9, 2022
@ektefa
Copy link

ektefa commented Feb 9, 2022

I saw this today too

@anoadragon453
Copy link
Member Author

@ektefa what is your Element version (Settings -> Help & About -> Versions) and operating system? That may help us track down when this regression was introduced.

@t3chguy t3chguy self-assigned this Feb 11, 2022
@t3chguy t3chguy mentioned this issue Feb 14, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Mar 5, 2022
@su-ex
Merge tag 'v15.6.0' into sc
8502dd1 
* Return send event response from MSC3089Branch.createNewVersion() ([\matrix-org#2186](matrix-org#2186)).
* Add functions to support refresh tokens ([\matrix-org#2178](matrix-org#2178)).
* [Release] Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2202](matrix-org#2202)).
* Fix bug where calls could break if rejected from somewhere else ([\matrix-org#2189](matrix-org#2189)).
* Fix camera stuck on after call transfer ([\matrix-org#2188](matrix-org#2188)).
* Fix synthetic read receipt handling ([\matrix-org#2174](matrix-org#2174)). Fixes element-hq/element-web#21016.
* Revert "Sign backup with cross-signing key when we reset it." ([\matrix-org#2175](matrix-org#2175)).
* Sign backup with cross-signing key when we reset it. ([\matrix-org#2170](matrix-org#2170)).
* Fix error in uploadContent() when file is empty under Node.js ([\matrix-org#2155](matrix-org#2155)).
* Check the backup info against the stored private key when determining trust. ([\matrix-org#2167](matrix-org#2167)).
* Back up keys before logging out ([\matrix-org#2158](matrix-org#2158)). Fixes element-hq/element-web#13151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Read-Receipts S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix synthetic read receipt handling matrix-org/matrix-js-sdk
4 participants
@anoadragon453 @t3chguy @ektefa @SimonBrandner