Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media captions in bubble layout #28480

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

tulir
Copy link
Contributor

@tulir tulir commented Nov 17, 2024

Fixes #28378

It was added in 4b5ca1d (matrix-org/matrix-react-sdk#7529), so I'm not sure if it's safe to remove, but with some quick testing I wasn't able to reproduce any more jumping around than the usual.

@t3chguy
Copy link
Member

t3chguy commented Nov 18, 2024

Fixes #28479

How does it fix that @tulir

@tulir
Copy link
Contributor Author

tulir commented Nov 18, 2024

Oof what, that's not what I tried to link, I think github's autocomplete messed up my pasting or something. Fixed now

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Nov 19, 2024
Merged via the queue into element-hq:develop with commit 0d5c9a3 Nov 19, 2024
43 of 45 checks passed
@tulir tulir deleted the fix-captions-with-bubbles branch November 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captions not rendered in bubble layout
3 participants