-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for runtime modules #29104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/modules-2025
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Will need to bypass coverage due to lack of ESM support in our Jest at this time. I added a Playwright test instead. |
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looking nice!
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…to t3chguy/modules-2025 Signed-off-by: Michael Telatynski <[email protected]> # Conflicts: # src/@types/global.d.ts # src/customisations/ChatExport.ts # src/customisations/ComponentVisibility.ts # src/customisations/WidgetVariables.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to replace https://github.com/matrix-org/matrix-react-sdk-module-api & https://github.com/element-hq/element-web/blob/develop/docs/customisations.md with a run-time alternative which will support similar use-cases and APIs.
Runtime extensions will make it easier to ship & test many variants of Element Web & Desktop and make it easier for consumers to make small tweaks without needing to fork or maintain their own CI/CD pipeline.
The initial implementation of runtime modules aims to replace the deprecated customisations & react-sdk-module-api by offering a way to load those legacy extensions via the new API. This is only temporary and to aid transition as we design the new API surface.
The intent is to provide a very stable API surface, with more being possible using unstable access to globals or by rendering things directly using ReactDOM, this strives to hit a flexible middle ground.
See https://github.com/element-hq/element-modules/tree/main/packages/element-web-module-api#readme