Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption tab: display correct encryption panel when user cancels the reset identity flow #29216

Merged

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 7, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

We weren't checking the encryption state when the user cancels the reset identity flow.

Before

Screen.Recording.2025-02-07.at.11.15.21.mov

After

Screen.Recording.2025-02-07.at.11.07.58.mov

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the before/after screen recording, it is helping a lot for context.
LGTM !

@florianduros florianduros added this pull request to the merge queue Feb 7, 2025
Merged via the queue into develop with commit 4a8ba81 Feb 7, 2025
86 checks passed
@florianduros florianduros deleted the florianduros/check-encryption-state-back-resent-identity branch February 7, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants