Rename "security key" into "recovery key"

[florianduros]

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26468
Rename "security key" into "recovery key". I didn't rename the i18n keys to avoid a huge change in all the translations.

[dbkr]

Wow, there were quite a few of these.

[andybalaam]

WOOHOO! I am guessing you are deliberately updating strings that are usually controlled by localazy?

[florianduros]

@andybalaam en_EN.json strings are not directly managed by localazy. They are the source of truth of the translations.

[richvdh]

Related: #27713

[richvdh]

I've got a few concerns about merging this as it is:

1. People may not realise that they can continue to use a "Security Key" where we now ask for a "Recovery Key". Of course, without this change, we have the opposite problem, so this is a weak argument, but...

2. Having "Security Key" littered throughout the codebase is actually quite a good guide for places we need to make sure we update properly to align with new designs. With a blanket s/Security Key/Recovery Key/, we lose this discriminator.

3. This introduces a new inconsistency between "Security Phrase" and "Recovery Key". For example, we now have this dialog:
   

   What do I do if I think I have a "Recovery Phrase"? I think I would probably click on the link, because I would focus on the "Recovery" bit rather than the "Security" bit. However, that is the wrong thing to do.

In short, I think I'd prefer an approach where we update each dialog/flow in turn to ensure that they use modern designs and copy.

Let's discuss further with @mxandreas.

[mxandreas]

In short, I think I'd prefer an approach where we update each dialog/flow in turn to ensure that they use modern designs and copy

@richvdh I am afraid we do not have an ideal (normal) solution here, because we already have updated some flows (like setting up recovery which talks about recovery key only), so one way or the other we have problem. Especially I am guessing that some models are re-used between flows.

The ideal would be to update all the modals to the new designs indeed where we take care of the "backward compatibility" (by saying that security key works, too); but it seems we struggle to afford it at once.