Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render reason for invite rejection. #29257

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Render reason for invite rejection. #29257

merged 4 commits into from
Feb 14, 2025

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Feb 13, 2025

Fixes #29256

This is a trivial change that will massively help out bot developers such as myself, so that users can see why the bot told them to go away.

Checklist

  • Tests written for new code (and old code if feasible).
  • [N/A] New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine code-wise, I think we can probably skip product / design for this as it's fairly obvious. My one concern is T&S so I've asked them to check (probably fine but I figure they would at least want to know).

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T&S say yes

@dbkr dbkr added this pull request to the merge queue Feb 14, 2025
Merged via the queue into develop with commit c47ce59 Feb 14, 2025
31 checks passed
@dbkr dbkr deleted the hs/reason-invite branch February 14, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element Web doesn't render invite rejection reasons
2 participants