Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plain-text handling for rich-text topics as per MSC3765 #18195

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Feb 28, 2025

This implements matrix-org/matrix-spec-proposals#3765 which is already merged and, therefore, can use stable identifiers.

For /publicRooms and /hierarchy, the topic is read from the eponymous field of the current_state_events table. Rather than introduce further columns in this table, I changed the insertion / update logic to write the plain-text topic from the rich topic into the existing field. This will not take effect for existing rooms unless their topic is changed. However, existing rooms shouldn't have rich topics to begin with.

Similarly, for server-side search, I changed the insertion logic of the event_search table to prefer the value from the rich topic. Again, existing events shouldn't have rich topics and, therefore, don't need to be migrated in the table.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@Johennes Johennes marked this pull request as ready for review February 28, 2025 10:01
@Johennes Johennes requested a review from a team as a code owner February 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant