Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed elm-brackets link to my repo #615

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Conversation

tommot348
Copy link
Contributor

@tommot348 tommot348 commented Jul 26, 2016

I have forked and fixed the elm-brackets extension, as it is no longer maintained and had issues with linux/mac. I also added some stuff like code hinting and formatting and plan on developing it further.

I have expanded the elm-brackets extension, as it is no longer maintained and had issues with linux/mac. I also added some stuff like code hinting and formatting and plan on developing it further.
@process-bot
Copy link

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz
Copy link
Member

evancz commented Jul 26, 2016

Can you get someone else to confirm what's going on?

@tommot348
Copy link
Contributor Author

Well, there are open issues on the original repo, to which the author himself replied that he has discontinued the project.
Am 26.07.2016 20:55 schrieb Evan Czaplicki [email protected]:Can you get someone else to confirm what's going on?

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

@evancz
Copy link
Member

evancz commented Jul 26, 2016

Give me a link to that.

I don't know stuff about brackets. Is there a "package install" thing as well? Will people be installing his or yours? Basically, if I am directing people to a project, will it work?

I need more information.

@tommot348
Copy link
Contributor Author

lepinay/elm-brackets#1
Brackets has a built-in extension manager. If you look for "elm" there, both his extension and mine will appear.
At the moment my extension is being worked on, but the version in the extension manager is working.
But I understand that you don't want to lose user due to bad tools, so if you have doubts, I would understand if you featured no link at all.
Am 26.07.2016 21:22 schrieb Evan Czaplicki [email protected]:Give me a link to that.

I don't know stuff about brackets. Is there a "package install" thing as well? Will people be installing his or yours? Basically, if I am directing people to a project, will it work?

I need more information.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

@evancz
Copy link
Member

evancz commented Jul 26, 2016

Great, thanks for the additional context!

I'd suggest adding install instructions to your README so people know how to get it more easily. I'd also check with the other person to see if you can get their version taken out of there or something. Or have it redirect to you. Unclear.

@evancz evancz merged commit b7c6b20 into elm:master Jul 26, 2016
@tommot348 tommot348 deleted the patch-1 branch July 27, 2016 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants