CloseablePopup: memo

enricoros · Feb 24, 2025 · 4e1ad84 · 4e1ad84
1 parent e90bcdf
commit 4e1ad84
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/common/components/CloseablePopup.tsx b/src/common/components/CloseablePopup.tsx
@@ -44,20 +44,22 @@ export function CloseablePopup(props: {
   children?: React.ReactNode,
 }) {
 
-  const handleClose = (event: MouseEvent | TouchEvent | React.KeyboardEvent) => {
+  const { onClose } = props;
+
+  const handleClose = React.useCallback((event: MouseEvent | TouchEvent | React.KeyboardEvent) => {
     event.stopPropagation();
-    props.onClose();
-  };
+    onClose();
+  }, [onClose]);
 
-  const handleKeyDown = (event: React.KeyboardEvent) => {
+  const handleKeyDown = React.useCallback((event: React.KeyboardEvent) => {
     if (event.key === 'Tab') {
       handleClose(event);
     } else if (event.key === 'Escape') {
       if (props.anchorEl)
         props.anchorEl?.focus();
       handleClose(event);
     }
-  };
+  }, [handleClose, props.anchorEl]);
 
 
   // memos