Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PILImage to pyface.api #1002

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Conversation

Palash-Vishnani
Copy link
Contributor

As per the issue #972 I have added optional import of PILImage and also added it in the miscellaneous section of module doc. Please suggest the changes, if I have done something wrong.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging now.

@rahulporuri
Copy link
Contributor

Thanks for the contributions @Palash-Vishnani ! We can close the issue #972 now.

Note : There seems to be something wrong with your branch history. It looks like the branch history from your previous PR (#997 ) is showing up on this branch. I just noticed that you opened a PR against the master branch on this repository from the master branch on your fork of PyFace. Usually, the git workflow recommends creating and commiting to a branch instead of commiting directly to master on a fork before openinig a PR.

You might find it useful to go through these guides - https://guides.github.com/

This isn't a problem for us though. We'll Squash merge the commits so I can clean up the commit message on the merge commit as necessary.

@rahulporuri rahulporuri merged commit a43c6e6 into enthought:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants