Fixes from investigating #1117 #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
added a commit
that referenced
this pull request
Jul 15, 2022
This was referenced Jul 15, 2022
corranwebster
added a commit
that referenced
this pull request
Jul 18, 2022
* Fixes from investigating #1117 (#1149) * Only delete attribute if it exists. * Use correct full name for MiddleButton. * Extract bytes rather than use QByteArray * Add test for SplitTabWeidget mouseReleaseEvent. * Remove unused imports. * Fix test and original middle button code. * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some drive-by fixes from issues found when investigating #1117. None of these actually fix the issue, however.
The changes to the state-saving code don't impact the file format, as no changes are needed for the reader (it can happily ingest both
QByteArrayandbytesobjects).