-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a TimeField class to Pyface #507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 39.76% 40.68% +0.92%
==========================================
Files 493 507 +14
Lines 27259 27695 +436
Branches 4140 4192 +52
==========================================
+ Hits 10840 11269 +429
- Misses 15944 15952 +8
+ Partials 475 474 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a bunch of mostly nitpicky comments.
Co-authored-by: Poruri Sai Rahul <[email protected]>
Co-authored-by: Poruri Sai Rahul <[email protected]>
This adds a time editing field to the
pyface.fields
API. This is a simple field with no bounds checking (Qt supports this Wx doesn't without significant additional work).The ulterior motive for this is to see if this can be the basis for the TraitsUI
TimeEditor
, allowing us to move all the toolkit-specific code down to Pyface. In the meantime, this will allow adding time editors to toolbars.