Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TimeField class to Pyface #507

Merged
merged 13 commits into from
Sep 28, 2021
Merged

Add a TimeField class to Pyface #507

merged 13 commits into from
Sep 28, 2021

Conversation

corranwebster
Copy link
Contributor

This adds a time editing field to the pyface.fields API. This is a simple field with no bounds checking (Qt supports this Wx doesn't without significant additional work).

The ulterior motive for this is to see if this can be the basis for the TraitsUI TimeEditor, allowing us to move all the toolkit-specific code down to Pyface. In the meantime, this will allow adding time editors to toolbars.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #507 into master will increase coverage by 0.92%.
The diff coverage is 93.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   39.76%   40.68%   +0.92%     
==========================================
  Files         493      507      +14     
  Lines       27259    27695     +436     
  Branches     4140     4192      +52     
==========================================
+ Hits        10840    11269     +429     
- Misses      15944    15952       +8     
+ Partials      475      474       -1     
Impacted Files Coverage Δ
pyface/ui/qt4/data_view/data_view_item_model.py 49.30% <38.46%> (-0.70%) ⬇️
pyface/fields/i_time_field.py 85.71% <85.71%> (ø)
pyface/ui/wx/data_view/data_wrapper.py 86.36% <86.36%> (ø)
pyface/data_view/i_data_wrapper.py 88.46% <88.46%> (ø)
...face/data_view/data_models/row_table_data_model.py 91.25% <91.25%> (ø)
pyface/ui_traits.py 86.11% <93.93%> (+2.32%) ⬆️
pyface/data_view/value_types/color_value.py 95.45% <95.45%> (ø)
pyface/color.py 100.00% <100.00%> (ø)
pyface/data_view/abstract_value_type.py 97.72% <100.00%> (+0.29%) ⬆️
pyface/data_view/data_models/data_accessors.py 100.00% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98015c...890d636. Read the comment docs.

@corranwebster corranwebster added this to the Release 7.4.0 milestone Sep 28, 2021
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a bunch of mostly nitpicky comments.

@corranwebster corranwebster merged commit 9dc8019 into main Sep 28, 2021
@corranwebster corranwebster deleted the feat/time-field branch September 28, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants