remove conditionals on python version

[aaronayres35]

fixes #601

[codecov-commenter]

Codecov Report

Merging #635 into master will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   39.22%   39.19%   -0.03%     
==========================================
  Files         491      491              
  Lines       26916    26905      -11     
  Branches     4069     4065       -4     
==========================================
- Hits        10557    10545      -12     
+ Misses      15903    15901       -2     
- Partials      456      459       +3     

Impacted Files	Coverage Δ
pyface/gui_application.py	77.89% <0.00%> (+2.38%)	⬆️
pyface/qt/__init__.py	71.73% <ø> (+2.98%)	⬆️
pyface/timer/i_timer.py	89.47% <100.00%> (+2.73%)	⬆️
pyface/ui/qt4/mimedata.py	85.29% <100.00%> (+3.60%)	⬆️
pyface/i_file_dialog.py	76.92% <0.00%> (-7.70%)	⬇️
pyface/ui/qt4/util/gui_test_assistant.py	77.87% <0.00%> (-2.66%)	⬇️
pyface/ui/wx/window.py	74.69% <0.00%> (-2.41%)	⬇️
pyface/wx/python_stc.py	9.14% <0.00%> (-1.22%)	⬇️
pyface/ui/qt4/code_editor/code_widget.py	43.31% <0.00%> (-0.85%)	⬇️
pyface/ui/qt4/console/console_widget.py	29.07% <0.00%> (-0.21%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990cbd2...c5918c6. Read the comment docs.

[rahulporuri]

Changes LGTM but i'm a little concerned about the changes in pyface.qt.__init__. Can you hold off on merging this until we can get another pair of eyes on this PR?

[aaronayres35]

Changes LGTM but i'm a little concerned about the changes in pyface.qt.__init__. Can you hold off on merging this until we can get another pair of eyes on this PR?

Yeah I will hold off, tbh I was a bit unsure myself - was curious for any feedback.

[kitchoi]

This code path still gets run in Python 3 with PyQt4. The outcome of this import side effect may not have been well tested, and it would be difficult to track down to this change if this removal should cause issues.
Are there other reasons for removing this apart from the comment and message surrounding it being Python 2 specific?

[aaronayres35]

No, it was simply removed because of the comment and Rahul saying we might be able to remove it on the original issue. To prevent potential additional headaches from its removal, I will add it back in - thanks!

[kitchoi]

I see. Yes please add it back in. Thank you!
Finger-crossed we won't need to support PyQt4 for much longer so this function is on already the death row - just not quite there yet :)

[aaronayres35]

Should I add back in the places where it was called? The one I'm most unsure about is the one below that was on line 61 as that if statement only occurs if python2 is being used explicitly.

(In the latest commit I added all the code where it was called that had been removed back. If needed I can re-remove it.

[kitchoi]

You're right - I think the one under if qt_api == "pyqt" and sys.version_info[0] <= 2: can be safely removed.