Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove border from Qt HeadingText. #692

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Sep 21, 2020

Fixes #664

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #692 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   39.72%   39.80%   +0.07%     
==========================================
  Files         492      492              
  Lines       27222    27220       -2     
  Branches     4134     4134              
==========================================
+ Hits        10815    10835      +20     
+ Misses      15935    15921      -14     
+ Partials      472      464       -8     
Impacted Files Coverage Δ
pyface/ui/qt4/heading_text.py 90.47% <ø> (-0.83%) ⬇️
pyface/ui/qt4/console/console_widget.py 29.28% <0.00%> (+0.20%) ⬆️
pyface/ui/qt4/code_editor/code_widget.py 44.16% <0.00%> (+0.84%) ⬆️
pyface/wx/python_stc.py 10.36% <0.00%> (+1.21%) ⬆️
pyface/ui/wx/window.py 77.10% <0.00%> (+2.40%) ⬆️
pyface/ui/qt4/util/gui_test_assistant.py 80.53% <0.00%> (+2.65%) ⬆️
pyface/ui/wx/data_view/data_view_widget.py 77.52% <0.00%> (+5.61%) ⬆️
pyface/__init__.py 88.88% <0.00%> (+7.40%) ⬆️
pyface/i_file_dialog.py 84.61% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33542a4...a110866. Read the comment docs.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit f9b1349 into master Sep 22, 2020
@corranwebster corranwebster deleted the fix/heading-text-box branch September 22, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HeadingText has strange border around it on Qt
3 participants