-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color and PyfaceColor Documentation #710
Conversation
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 39.76% 40.53% +0.76%
==========================================
Files 493 502 +9
Lines 27259 27614 +355
Branches 4140 4185 +45
==========================================
+ Hits 10840 11193 +353
- Misses 15944 15950 +6
+ Partials 475 471 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small correction. Haven't tested the built docs though.
the color to use in part of the UI. Each toolkit usually has its own way of | ||
representing colors, and so the ability to specify a color in a | ||
toolkit-independent way that can be converted to a toolkit-specific | ||
representation is important. This is particularly so when you want to allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
representation is important. This is particularly so when you want to allow | |
representation is important. This is particularly important when you want to allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer the "so" - it references pack to the "important" in the previous sentence without repeating the word.
Add documentation for the
Color
class andPyfaceColor
trait.