Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running CI on traits 6.0 #865

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

aaronayres35
Copy link
Contributor

fixes #781

This PR updates the travis.yml file to require traits 6.1+ not 6.0+. It also removes a traits version check that prevented data_view test from being run for traits !=6.1. Not we will want these tests to run on 6.2+ as well.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two changes, we will also want to specify in setup.py that we require traits>=6.2.0.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM.

The fishy thing (that i suspect but have not verified) is that traits 6.1.1 is probably installed via edm first - and then updated to traits 6.2.0 via pip because of the change in version requirement. Can you confirm this?

If that is indeed the case, I would hold off on merging this PR until traits 6.2.0 is available via edm - and rerun CI on this PR, just to be super safe (and to calm my super paranoia).

@aaronayres35
Copy link
Contributor Author

I think this LGTM.

The fishy thing (that i suspect but have not verified) is that traits 6.1.1 is probably installed via edm first - and then updated to traits 6.2.0 via pip because of the change in version requirement. Can you confirm this?

If that is indeed the case, I would hold off on merging this PR until traits 6.2.0 is available via edm - and rerun CI on this PR, just to be super safe (and to calm my super paranoia).

It looks like CI is actually just being run with traits 6.1 from edm currently, even though the setup.py explicitly requires traits 6.2+. There are no explicit version restrictions on the CI config files as the PR currently stands. I will wait until 6.2 is available through edm and rerun CI on this PR

@rahulporuri
Copy link
Contributor

Rerunning CI now that Travis 6.2.0 is available via EDM.

@rahulporuri
Copy link
Contributor

Looks like traits 6.2.0 is now being used in the CI. Still LGTM.

@aaronayres35 aaronayres35 merged commit f3683d0 into master Jan 27, 2021
@aaronayres35 aaronayres35 deleted the stop-running-ci-traits-6.0 branch January 27, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop doing CI runs with Traits 6.0
2 participants