Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the events correctly #915

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Handle the events correctly #915

merged 1 commit into from
Mar 26, 2021

Conversation

rahulporuri
Copy link
Contributor

This was missed in the on_trait_change to observe changes introduced in #880 . The methods were previously receiving
obj as an argument to the trait change handler which should have been replaced with event.object in #880.

This was discovered when fixing F821 flake8 failures in pyface.

FIX : Handle the events correctly
9a88f32 
This was missed in the `on_trait_change` to `observe` changes
introduced in #880 . The methods were previously receiving
`obj` as an argument to the trait change handler which should
have been replaced with `event.object` in #880.
aaronayres35
aaronayres35 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch, thank you!

@rahulporuri rahulporuri merged commit aef3b51 into master Mar 26, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch March 26, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulporuri @aaronayres35