Dont complain about old versions of PyQt4 and Qt4 #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops support for very old versions of PyQt4 and Qt4, specifically < 4.1 for PyQt4 and < 4.2 for Qt4. This is acceptable as the only available versions of PyQt4 on EDM for Python 3 are >= 4.11
aaronayres35
approved these changes
Apr 26, 2021
Comment on lines
-23
to
-31
| if QtCore.QT_VERSION < 0x040200: | ||
| raise RuntimeError( | ||
| "Need Qt v4.2 or higher, but got v%s" % QtCore.QT_VERSION_STR | ||
| ) | ||
|
|
||
| if QtCore.PYQT_VERSION < 0x040100: | ||
| raise RuntimeError( | ||
| "Need PyQt v4.1 or higher, but got v%s" % QtCore.PYQT_VERSION_STR | ||
| ) |
There was a problem hiding this comment.
seems as though we weren't supporting these anyway, just raising saying version is too old
There was a problem hiding this comment.
Ahh. Right. Updated the PR title and description.
rahulporuri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the runtime errors that were being reaised for very old versions of PyQt4 and Qt4, specifically
< 4.1for PyQt4 and< 4.2for Qt4. This is acceptable as the only available versions of PyQt4 on EDM for Python 3 are>= 4.11.