Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add support for getTopSongs #365

Closed
GioF71 opened this issue Nov 11, 2023 · 4 comments
Closed

[Request] Add support for getTopSongs #365

GioF71 opened this issue Nov 11, 2023 · 4 comments
Milestone

Comments

@GioF71
Copy link

GioF71 commented Nov 11, 2023

Hello, would it be possible to add support for the getTopSongs method in the subsonic api implementation?
Currently I get a "Not implemented" exception (through py-sonic).

Thank you for your attention.

@epoupon
Copy link
Owner

epoupon commented Nov 11, 2023

It's not implemented because of this : "Returns top songs for the given artist, using data from last.fm."
Maybe lms can fallback on the local playcount though

@GioF71
Copy link
Author

GioF71 commented Nov 11, 2023

You are right, I did not notice the remark about last.fm. Other server have support for last.fm, so maybe this could be implemented using that data if you choose to add this aspect to your application.

I have already added some code to my plugin so now I can handle the unimplemented call more gracefully, but yes, maybe returning something related with local playcount might be very much ok!

@epoupon
Copy link
Owner

epoupon commented Dec 15, 2023

Juste noticed this endpoint (http://www.subsonic.org/pages/api.jsp#getTopSongs) is using an artist name to lookup for the artist: LMS will raise an error if multiple matching artists are found.

@epoupon epoupon added this to the v3.46.0 milestone Dec 15, 2023
@epoupon epoupon closed this as completed Dec 15, 2023
@GioF71
Copy link
Author

GioF71 commented Dec 16, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants