Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist image not showing if the artist also appears in a compilation. #398

Closed
nonylours opened this issue Jan 6, 2024 · 3 comments
Closed
Labels
Milestone

Comments

@nonylours
Copy link

Hi, I have a few issues with the new artists image feature.

My music is organized like this:

Artists
/music/artist A/artist.jpg
/music/artist A/album A/artist A - song.mp3

Compilations
/music/various artists/compilation A/artist A - song.mp3 (Album artist tag is “Various Artists”, Artist tag is “Artist A”)

In Symfonium, the artist A image won’t be displayed if the artist also appears in a compilation.

I don’t know where LMS is looking for the image. The log just throws a 404 error:
2024-01-06 14:03:12 [2024-Jan-06 05:03:12.695] 1 - [info] "wthttp: 172.17.0.1 GET /rest/getCoverArt.view?id=ar-695&u=X&p=X&v=1.13.0&c=Symfonium&f=json HTTP/1.1 404 0"

I don’t know if it’s related, but I also have an issue with albums with several artists:

/music/artist A/artist.jpg
/music/artist A/album A/artist A - song.mp3
/music/artist A/album A/artist B - song.mp3 (Album artist tag is “Artist A”. Artist tag is “Artist B”. Artist B doesn’t appear anywhere else in the library.)

For artist B, Symfonium will show Artist A image.

Thanks.

@epoupon
Copy link
Owner

epoupon commented Jan 6, 2024

Hello!
Indeed LMS tries to find the artist.jpg file in the longest common path of all the files that belong to the artist (in your case /music/)
If it does not find something, it will try in each folder that holds at least a music file for this artist (in your case /music/artist A/album A/ and /music/various artists/compilation A/)

Maybe we can change the later to look for an artist file in all parent paths, but I am afraid about bringing even more problems? (but various artists should not have an artist file)

@epoupon epoupon added the bug label Jan 6, 2024
@epoupon epoupon added this to the v3.46.1 milestone Jan 6, 2024
@nonylours
Copy link
Author

I tried putting artist.jpg in one of the album folders, and it showed up. Thanks.

Maybe LMS could use the album artist tag to search for artist.jpg? Or only check files where the artist tag and album artist tag are the same? In my case, LMS would only search in /music/artist A/. This would also solve the second issue with guest artists.

@epoupon
Copy link
Owner

epoupon commented Jan 7, 2024

Indeed that makes sense to only check for album artists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants