Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album covers: do not fallback on random image #503

Closed
epoupon opened this issue Jul 27, 2024 · 11 comments
Closed

Album covers: do not fallback on random image #503

epoupon opened this issue Jul 27, 2024 · 11 comments
Milestone

Comments

@epoupon
Copy link
Owner

epoupon commented Jul 27, 2024

For now, LMS first tries to match an external file in the directory of the release. This is controlled by cover-preferred-file-names in lms.conf.
If no preferred file is found, a random file is picked up. This is not good as it may pick some unrelated image.

@Bigmack3000
Copy link

Hey, I just updated to the latest version. I'm still seeing back covers and booklets for a lot of albums, instead of the embedded cover art. I don't see a place in options to choose a preference.

@epoupon
Copy link
Owner Author

epoupon commented Sep 3, 2024

Yes, the issue is still open!

@Bigmack3000
Copy link

Ha, fair enough. I missed that.

@epoupon epoupon added this to the v3.59.0 milestone Sep 21, 2024
@epoupon
Copy link
Owner Author

epoupon commented Sep 27, 2024

Ok, rethought about it
@Bigmack3000 : if I understand correctly, your problem is that LMS picks images that are not the front one, like "back" etc?
I think I will change LMS to be less permissive (like other players actually) and just pick names like cover, folder, front. And then fallback on embedded images.

@Bigmack3000
Copy link

So every album has a front cover already embedded into it. Some albums have additional photos, like back, inserts, etc.

LMS seems to ignore the embedded image if there's any other photo in the folder. I would like LMS to always choose the embedded images first.

@epoupon
Copy link
Owner Author

epoupon commented Sep 27, 2024

Yes, but if lms only picks files named cover, front and folder, and then fallbacks on embedded cover, it will be ok too?
Just trying to make thinks easier to develop and maintain

@Bigmack3000
Copy link

I would imagine that works. Or even an option to choose between embedded or external images.

Separately, and just thinking of it now, down the line it might be nice to also be able to scroll through the extra photos on an albums page.

@epoupon
Copy link
Owner Author

epoupon commented Sep 27, 2024

Ahah, I was wondering when one would ask for that!

@epoupon epoupon changed the title Add a way to set release cover lookup preferences Album covers: do not fallback on random image Sep 29, 2024
@epoupon epoupon closed this as completed Sep 29, 2024
@Bigmack3000
Copy link

Hey, I've updated and all the album covers look perfect now! Thanks!

@epoupon
Copy link
Owner Author

epoupon commented Oct 21, 2024

Thanks for your feedback!

@smooveg1
Copy link

smooveg1 commented Jan 8, 2025

Hi there, since this thread was referred to in #499, I was wondering if there was any way to ensure that LMS picks up other artist images, specifically composer.jpg and conductor.jpg. I have cases where these are applicable for entire releases but also where they are track specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants