Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

, and ; #518

Closed
VlaK0r opened this issue Sep 2, 2024 · 8 comments
Closed

, and ; #518

VlaK0r opened this issue Sep 2, 2024 · 8 comments
Milestone

Comments

@VlaK0r
Copy link

VlaK0r commented Sep 2, 2024

Hello! Thank you for your work!

изображение
изображение

There is the following list of artists filled with MusicBrainz Picard.

изображение

Artists are divided ; are counted as one artist.
We are talking about [Album artists]
изображение

Please tell me how to fix this?

@epoupon
Copy link
Owner

epoupon commented Sep 2, 2024

Ah, I recommend to use a custom tag for that, see https://github.com/epoupon/lms?tab=readme-ov-file#multiple-album-artists

@VlaK0r
Copy link
Author

VlaK0r commented Sep 2, 2024

изображение

Thank you! So this setting can be removed? Won't it help?

@epoupon
Copy link
Owner

epoupon commented Sep 2, 2024

Well it is another mean to split, less reliable, but it should have worked too.
Did you rescan after having set these separators?

@VlaK0r
Copy link
Author

VlaK0r commented Sep 2, 2024

Did you rescan after having set these separators?

Yes, I did, but it did not give a result.

@epoupon
Copy link
Owner

epoupon commented Sep 3, 2024

Ah now I understand, LMS only uses the first delimiter hit. Here the first is , so it considers this is the only one to use for the whole string, to avoid unwanted further splits.
But this is highly debatable...

@epoupon
Copy link
Owner

epoupon commented Sep 6, 2024

So not sure to do with this. We could blindly apply all delimiters set, or you could add albumartists to the tags of this album.
This makes also me think LMS tries to split tags in artists and albumartists, which may lead to bad results for correctly split artists in multi-valued tags

@VlaK0r
Copy link
Author

VlaK0r commented Sep 6, 2024

Ah, I recommend to use a custom tag for that, see https://github.com/epoupon/lms?tab=readme-ov-file#multiple-album-artists

It's okay, your way works. I took advantage of it and everything worked out.

@epoupon
Copy link
Owner

epoupon commented Sep 7, 2024

In order to be more consistent, lms now applies all separators on tags.

@epoupon epoupon closed this as completed Sep 7, 2024
@epoupon epoupon added this to the v3.58.0 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants