Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] enable loading of unsynced lyrics in txt files #582

Closed
hlinden opened this issue Jan 2, 2025 · 5 comments
Closed

[feature request] enable loading of unsynced lyrics in txt files #582

hlinden opened this issue Jan 2, 2025 · 5 comments
Milestone

Comments

@hlinden
Copy link

hlinden commented Jan 2, 2025

Currently, my favourite(tm) lyrics tool writes synced lyrics as .lrc and unsynced lyrics as .txt.

I'm no developer, but if I read it correctly, the logic here should already handle unsynced lyrics just fine. Would it be possible to just add ".txt" to the list of file extensions here and be done with that, or am I overlooking something?

@epoupon
Copy link
Owner

epoupon commented Jan 2, 2025

Hello! Yes it should work but afaiu you should already have your lyrics loaded by lms thanks to the .lrc files?

@hlinden
Copy link
Author

hlinden commented Jan 2, 2025

I have a mixture of synced and non-synced lyrics in my collection. .lrc are the synced ones, .txt are the unsynced ones. This is the default naming convention for LRCGET, so I'd assume other people have the same situation.

Other players I'm using like Tauon and Jellyfin work fine with that, so I would prefer not to rename the unsynced lyrics to .lrc and therefore make them indistinguishable from the synced ones, at least in a simple way.

So, if it's really just adding ".txt" to the file suffixes that are parsed, it would be nice if you could do so. If that implies more changes that I don't see right now, then, forget it, I'd just write myself a little maintenance script that moves txt to lrc regularly.

@epoupon
Copy link
Owner

epoupon commented Jan 2, 2025

My bad I thought your software was saving both versions for the same track.
Yes it is definitely possible to parse txt files for lyrics.

@epoupon epoupon added this to the v3.63.0 milestone Jan 2, 2025
@epoupon epoupon closed this as completed Jan 5, 2025
@hlinden
Copy link
Author

hlinden commented Jan 25, 2025

This now works exactly as expected in v3.63.0. Thank you very much!

@epoupon
Copy link
Owner

epoupon commented Jan 25, 2025

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants