Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the treatment of the debug option so that a port can be set in c... #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edsykes
Copy link

@edsykes edsykes commented Mar 25, 2015

...onfiguration from the grunt file

Hi eric,

while running multiple node apps and wanting to debug them, I found that I couldn't set a debug port through the configuration in the grunt file. After investigating I found that the grunt task doesn't pick up the port - just whether debug is set or not.

I couldn't see any tests for the debug settings - so wasn't sure where to put the test for this, or indeed how to test this. If you'd like a test, please suggest where to put it and perhaps how best to test it.

Ed

@drawveloper
Copy link
Collaborator

@ericclemmons LGTM 🌟

@aheuertz
Copy link

aheuertz commented Apr 3, 2015

+1 .. this fix is very helpful for my multi-app setup

@ericclemmons
Copy link
Owner

I'm eager to merge this down, but I'm not quite...sure what it does? @edsykes Can you add an example of this in the project's Gruntfile.js? That'll help serve as a test, kinda how I have now for custom ports:

@edsykes
Copy link
Author

edsykes commented Apr 15, 2015

will do - it will take me a few days to get to this. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants