Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: fix Windows build after PR 2686 #2689

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

canepat
Copy link
Member

@canepat canepat commented Jan 31, 2025

No description provided.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.60%. Comparing base (cd80428) to head (04ceed9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
silkworm/db/datastore/domain_get_as_of_query.hpp 0.00% 1 Missing ⚠️
silkworm/db/datastore/history_get_query.hpp 0.00% 1 Missing ⚠️
silkworm/db/datastore/snapshots/basic_queries.hpp 0.00% 1 Missing ⚠️
...kworm/db/datastore/snapshots/history_get_query.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   50.61%   50.60%   -0.01%     
==========================================
  Files         809      809              
  Lines       53132    53132              
  Branches     8274     8274              
==========================================
- Hits        26892    26887       -5     
- Misses      23892    23898       +6     
+ Partials     2348     2347       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat marked this pull request as ready for review January 31, 2025 21:33
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 31, 2025
@canepat canepat requested a review from battlmonstr January 31, 2025 21:59
@canepat canepat merged commit 204a86e into master Jan 31, 2025
16 of 17 checks passed
@canepat canepat deleted the ci/fix_clang_tidy_after_2686 branch January 31, 2025 22:00
@battlmonstr
Copy link
Contributor

battlmonstr commented Feb 1, 2025

What was the problem here? Some of that code existed from before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants