Fix tests in Windows; adjust absolute paths #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with OTP-22, Erlang started changing how volume names are handled in windows: filename:join/1 drops drive letters, filename:split/2 and file:absname/1 use c:/ as a form instead of c:\\ We adjust the file_utils and their tests accordingly. Rebar3.14 has new tests that were not windows ready and those are fixed. Relx has two failing tests that are not covered in this branch. Tested in Windows 10 with Powershell.
|
Added a commit that fixes #2273 |
tsloughter
reviewed
May 18, 2020
| {ok, Dir} = file:get_cwd(Volume), | ||
| filename:join([Dir, Path]) | ||
| Volume ++ filename:join([Dir, Path]) |
There was a problem hiding this comment.
So Erlang has no way to include the volume in the path? Or is this just so it works on both otp-23 and older otps?
There was a problem hiding this comment.
you can get it in absname, but filename:join drops it... so I have to add it after the fact.
tsloughter
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with OTP-22, Erlang started changing how volume names are handled in
windows: filename:join/1 drops drive letters, filename:split/2 and
file:absname/1 use c:/ as a form instead of c:\\
We adjust the file_utils and their tests accordingly.
Rebar3.14 has new tests that were not windows ready and those are fixed.
Relx has two failing tests that are not covered in this branch.
Tested in Windows 10 with Powershell.