Fix Recursive Behaviour Lookup Regression #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to a subtle mistake in the new code in erlang#2322 which optimized the search behaviour of files not found by EPP. The patch mistakenly always kept the top-level src/ directory for an app even if it did a lookup in recursive ones. This patch tracks and maintains the proper subdirectory hierarchy. To keep performance adequate, the lists:keyfind/3 function is used, which is also now a NIF to the same extent as lists:member/2; manual lookups would likely end up reducing performance, particularly in deep hierarchies. A test case has been added to track the regression. Reported by @elbrujohalcon
elbrujohalcon
approved these changes
Sep 1, 2020
tsloughter
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to a subtle mistake in the new code in
#2322 which optimized the search
behaviour of files not found by EPP. The patch mistakenly always kept
the top-level src/ directory for an app even if it did a lookup in
recursive ones.
This patch tracks and maintains the proper subdirectory hierarchy. To
keep performance adequate, the lists:keyfind/3 function is used, which
is also now a NIF to the same extent as lists:member/2; manual lookups
would likely end up reducing performance, particularly in deep
hierarchies.
A test case has been added to track the regression.
Reported by @elbrujohalcon
CC @max-au