Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken lager_console_backend backend #1832

Merged
merged 1 commit into from
May 7, 2018
Merged

Conversation

arcusfelis
Copy link
Contributor

At some point we broke logs in the live shell, i.e.

_build/mim1/rel/mongooseim/bin/mongooseim console

Log message in log/ejabberd.log:

Lager fatally failed to install handler lager_console_backend into
lager_event, NOT retrying: {bad_console_config, info}

Log message:
Lager fatally failed to install handler lager_console_backend into
lager_event, NOT retrying: {bad_console_config, info}
@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #1832 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
- Coverage   74.77%   74.77%   -0.01%     
==========================================
  Files         297      297              
  Lines       27737    27737              
==========================================
- Hits        20740    20739       -1     
- Misses       6997     6998       +1
Impacted Files Coverage Δ
src/mod_mam_muc_odbc_async_pool_writer.erl 70.73% <0%> (-3.26%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 82.6% <0%> (-2.18%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 79.57% <0%> (-0.71%) ⬇️
src/mod_muc.erl 72.62% <0%> (-0.28%) ⬇️
src/mod_muc_log.erl 77.69% <0%> (-0.26%) ⬇️
src/mod_roster.erl 78.92% <0%> (-0.25%) ⬇️
src/ejabberd_c2s.erl 84.35% <0%> (-0.23%) ⬇️
src/mod_muc_room.erl 77.3% <0%> (-0.18%) ⬇️
src/mod_pubsub.erl 66.07% <0%> (+0.06%) ⬆️
src/mod_mam_utils.erl 88.44% <0%> (+0.66%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596fbc5...185381b. Read the comment docs.

@fenek fenek merged commit 9dfbf5d into master May 7, 2018
@fenek fenek deleted the fix-broken-console-lager branch May 7, 2018 08:03
@fenek fenek added this to the 3.0.0 milestone May 7, 2018
fenek added a commit that referenced this pull request May 17, 2018
Revert "Fix broken lager_console_backend backend"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants