Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go 1.24.0 #907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Elbehery
Copy link
Member

@ivanvc
Copy link
Member

ivanvc commented Feb 20, 2025

@Elbehery, please update the golangci-lint version to 1.64.5. As I mentioned it in etcd-io/raft#268 (comment)

@Elbehery
Copy link
Member Author

@ivanvc raised #915

@Elbehery Elbehery force-pushed the 20250216-bump-go1.24.0 branch from 1d1ef49 to 9d81a48 Compare February 21, 2025 14:05
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery
Copy link
Member Author

raised #916 to fix windows linter

@Elbehery
Copy link
Member Author

/retest-required

@ivanvc
Copy link
Member

ivanvc commented Feb 21, 2025

@Elbehery, it looks like the tests are hanging and timing out in Prow. I noticed that the previous jobs were killed after 48 hours. Can you run them locally and check if they're not finishing? It's weird because they have a -timeout 30m argument 🤔

@Elbehery
Copy link
Member Author

/retest

@Elbehery Elbehery force-pushed the 20250216-bump-go1.24.0 branch from a04120f to 8a6b543 Compare February 22, 2025 05:38
@Elbehery
Copy link
Member Author

@Elbehery, it looks like the tests are hanging and timing out in Prow. I noticed that the previous jobs were killed after 48 hours. Can you run them locally and check if they're not finishing? It's weird because they have a -timeout 30m argument 🤔

@ivanvc I ran locally

make test

and it passes 👍🏽

I suggest to bump the timeout, because the freeList tests takes long time

wdyt @ahrtr about bumping the timeout ?

@Elbehery
Copy link
Member Author

/retest

Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery force-pushed the 20250216-bump-go1.24.0 branch from 8a6b543 to ff1a2dd Compare February 22, 2025 12:33
@Elbehery
Copy link
Member Author

@ivanvc I don't know how to fix this 🤔

any suggestions ?

@ivanvc
Copy link
Member

ivanvc commented Feb 22, 2025

Increasing the timeout, I don't think, will make any difference, as it clearly is not terminating after the current set timeout.

I would start troubleshooting by debugging the script in the Prow infrastructure. You can add a set set -x in the Makefile or try to adjust the verbosity of the test execution. You can add a debug line at the end of the tests to see if it's hanging in the CI or on the side of the tests.

If you feel this is something beyond what you could do, we can reassign this version upgrade to me, and I'll take a look at it later.

@Elbehery
Copy link
Member Author

Increasing the timeout, I don't think, will make any difference, as it clearly is not terminating after the current set timeout.
I would start troubleshooting by debugging the script in the Prow infrastructure. You can add a set set -x in the Makefile or try to adjust the verbosity of the test execution. You can add a debug line at the end of the tests to see if it's hanging in the CI or on the side of the tests.
If you feel this is something beyond what you could do, we can reassign this version upgrade to me, and I'll take a look at it later.

I will continue but mid week, hope it is fine 👍🏽

@ivanvc
Copy link
Member

ivanvc commented Feb 22, 2025

That sounds good. Can you draft the pull request to avoid generating the never-ending prow jobs? We can manually trigger the tests for draft pull requests. I'll also open a PR in test-infra to add a timeout to the jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants