Use strict synchronization for revision getter to minimize flaky result caused by time racing. #17513
Conversation
|
Hi @joshuazh-x. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
…lt caused by time racing. Signed-off-by: Joshua Zhang <[email protected]>
joshuazh-x
force-pushed
the
force_sync_rev_getter
branch
from
50cf6cf to
5a02f05
Compare
|
@joshuazh-x could you rebase this PR? |
| var timeoutC <-chan time.Time | ||
| if r.waitTimeout < math.MaxInt64 { | ||
| timeoutC = time.After(r.waitTimeout) | ||
| } |
There was a problem hiding this comment.
Suggest to follow the pattern "A Timeout of zero means no timeout."
There was a problem hiding this comment.
@joshuazh-x @ahrtr I'd like to address this comment as we are seeing TestPeriodic tests flaking frequently in our CI. Please let me know if I can proceed or if there are any other plans to take it forward.
There was a problem hiding this comment.
If there is no feedback from @joshuazh-x next week, please feel free to create a new PR. thx
There was a problem hiding this comment.
@ahrtr I am creating a new PR then with similar changes and review comments addressed. TY !
There was a problem hiding this comment.
I have cherry-picked the change and addressed review comments here, #18608 . Could you please take a look ?
thanks !
|
Superseded by #18608 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
for issue #17054 and #17487