-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: fix json output #19469
base: main
Are you sure you want to change the base?
etcdctl: fix json output #19469
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kstrifonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kstrifonoff. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4de0af7
to
237116d
Compare
Fixed an issue related to the printing of IDs in decimal or hexadecimal formats. Signed-off-by: Kirill Trifonov <[email protected]>
237116d
to
d39583f
Compare
/cc @ivanvc |
Hi @kstrifonoff, thanks for the pull request. I'm respectful to the original contributor who asked to work on this. Our guideline is to re-assign after a week of no answer when asking a contributor for updates. A couple of suggestions by quickly looking at the code.
Thanks again for your pull request :) |
Fix #19262