Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/openethereum specs #157

Merged
merged 12 commits into from
Jul 27, 2020
Merged

Feat/openethereum specs #157

merged 12 commits into from
Jul 27, 2020

Conversation

meowsbits
Copy link
Contributor

@meowsbits meowsbits commented Jul 27, 2020

ℹ️ This is on top of #156. Merge after that one.

Updates parity.json.d chain specs against upstream openethereum/openethereum.

  • renames files
  • refactored test specs to test-specs dir
  • adds BLS curve precompiles to foundation.json spec (activated in far-distant future)

Associated updates and changes:

  • regenerate tests based on these new configs 4b8d352
  • Install EIP2537 getter/setter implementation for Parity config data type 5089bec

meowsbits added 12 commits July 27, 2020 09:06
This orders them developmentally-chronologically
and puts unit tests first, with regression (integration)
last.

Signed-off-by: meows <[email protected]>
Ropsten flag was addded to supersede 'testnet',
and should have a test case here.

When --testnet is finally removed, the associated
test case may be removed as well.

Signed-off-by: meows <[email protected]>
'geth' is no longer an available option.

This refactors to use the global chain format
dictionary, unifying the app's option declaration
and logic.

Signed-off-by: meows <[email protected]>
NetworkID is allowed to be zero.

Although this is an edge case in practice,
occuring only on the Olympic network and in
some test configurations.

Signed-off-by: meows <[email protected]>
…path

Updates to work with their refactoring dir
system.

Signed-off-by: meows <[email protected]>

params/parity.json.d/sync-parity-remote.sh: !squashme - test-spec filepath rename

Signed-off-by: meows <[email protected]>
…om parity-available configs

They removed ETC configurations from their defaults.
https://github.com/openethereum/openethereum/pull/11821

Signed-off-by: meows <[email protected]>
…d/eip158_to_byzantiumat5_test.json.json,params/parity.json.d/foundation.json,params/parity.json.d/ropsten.json,params/parity.json.d/transition_test.json: sync parity configs

Signed-off-by: meows <[email protected]>
Files were renamed at openethereum/openethereum.

The generated tests will need to be regenerated as well,
since they include the filenames and shasums of the
test spec files.

Signed-off-by: meows <[email protected]>

params/parity.json.d/sync-parity-remote.sh: !squashme - fix typo in test name

Signed-off-by: meows <[email protected]>

tests: !squashme fix typo in generate config:file map

Signed-off-by: meows <[email protected]>

params/parity.json.d/eip158_to_byzantiumat5_test.json,params/parity.json.d/eip158_to_byzantiumat5_test.json.json: !squashme fix filepath for parity byzantiumat5 test"

Signed-off-by: meows <[email protected]>
Regenerated tests included the latest changes from
openethereum/openethereum. These changes were
renamings of test spec files, transition_test ->
eip158_to_byzantiumat5 and st_peters -> constantinople_fix

Signed-off-by: meows <[email protected]>
Install support for OpenEthereum data type for
EIP2537 configuration feature.

EIP2537 adds 9 precompiles for BLS12-381 curve.

Signed-off-by: meows <[email protected]>

parity: (lint) goimports -w

Signed-off-by: meows <[email protected]>

parity: !squashme fix typo

Signed-off-by: meows <[email protected]>
@meowsbits meowsbits self-assigned this Jul 27, 2020
@meowsbits meowsbits merged commit ae8ba1e into master Jul 27, 2020
@meowsbits meowsbits deleted the feat/openethereum-specs branch July 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant