Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: add default snap discovery to config during setup #394

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

meowsbits
Copy link
Contributor

This is behavior established at ethereum/go-ethereum for
now, though the snap-specific protocol DNS registrations
are disused; assumes coexistance of eth and snap protos.

Date: 2021-06-07 14:11:47-05:00
Signed-off-by: meows [email protected]

This is behavior established at ethereum/go-ethereum for
now, though the snap-specific protocol DNS registrations
are disused; assumes coexistance of eth and snap protos.

Date: 2021-06-07 14:11:47-05:00
Signed-off-by: meows <[email protected]>
@meowsbits meowsbits requested a review from ziogaschr June 7, 2021 19:12
@meowsbits meowsbits self-assigned this Jun 7, 2021
Copy link
Member

@ziogaschr ziogaschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's keep our eyes open, for when they use the correct bootnodes at ethereum/go-ethereum or when we feel that a good percentage of nodes at ETC are running with snap on.

@meowsbits meowsbits merged commit 08e2aae into master Jun 8, 2021
@meowsbits meowsbits deleted the fix/snap-discovery-urls branch June 8, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants