Merge/foundation release/1.10.15 #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes #23837
* eth/tracers: restructure tracer package * core/vm/runtime: load js tracers * eth/tracers: mv bigint js code to own file * eth/tracers: add method docs for native tracers * eth/tracers: minor doc fix * core,eth: cancel evm on nativecalltracer stop * core/vm: fix failing test Co-authored-by: Sina Mahmoodi <[email protected]>
Debugging recent geth failures in hive, it took a while to realize that it's because geth doesn't support eth/65 any longer. This PR makes such failures a bit more easy to figure out.
Neigbors -> Neighbors
p2p: fix typo in v4wire.go
This retroactively implements requirements or EIP-2681 for the account nonce upper limit.
* eth/tracers: add slow path for getting legacy logs * core/rawdb: fix test
This was apparently recently changed by Cloudflare, and began returning an error: 'TTL must be between 60 and 86400 seconds, or 1 for Automatic' Date: 2021-11-10 15:25:20-08:00 Signed-off-by: meows <[email protected]>
* native 4byte tracer * Update eth/tracers/native/4byte.go Co-authored-by: Martin Holst Swende <[email protected]> * Update eth/tracers/native/4byte.go Co-authored-by: Martin Holst Swende <[email protected]> * goimports * eth/tracers: make 4byte tracer not care about create Co-authored-by: Martin Holst Swende <[email protected]>
…(#23898) Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.
* cmd/evm: add gas used accumulator to t8n result * cmd/evm: update t8n tests to include gas used field
* core/rawdb: better error message in freezer * Apply suggestions from code review
* cmd, core: add flag --dev.gaslimit to allow configuring initial block gas limit in dev mode * core: use provided gaslimit Co-authored-by: Martin Holst Swende <[email protected]>
This fixes a bug in TransactionSender where it would return the zero address for transactions where the sender address wasn't cached already. Co-authored-by: Felix Lange <[email protected]>
evm block-builder (a.k.a b11r) is a utility to help assemble blocks, for use during the test-creation process.
core, eth/downloader: fix resetting below freezer threshold
…at (#23937) * cmd/evm: add support for signing transactions in the unprotected format * cmd/evm: simplify signing of unprotected txs
core/vm: don't use iota for opcode definitions
…#23612) * core/rawdb: utilize AncientRange when initiating from freezer * core/rawdb: remove debug sanity check
…nal/tracetest/testdata/call_tracer_parity,eth/tracers/internal/tracetest/testdata/state_diff,eth/tracers/js/internal/tracers: relocate JS tracer testdata
…uff from core-geth in JS tracers which has been wrongly removed after upstream merge
Signed-off-by: meows <[email protected]>
This just simplifies the code by reusing an existing ChainHeaderReader interface instead of reinventing the interface for the the forker. Date: 2022-01-24 14:11:14-08:00 Signed-off-by: meows <[email protected]>
The replaces a custom reorgData data type and associated custom (to core-geth) logic with as much go-ethereum code as possible. Reorg disallowance via MESS is now handled in the ForkChoice.ReorgNeeded logic ONLY. A new function ForkChoice.CommonAncestor is introduced as a utility function, and a simple unit test is provided for it. Date: 2022-01-24 14:15:29-08:00 Signed-off-by: meows <[email protected]>
Date: 2022-01-24 14:16:47-08:00 Signed-off-by: meows <[email protected]>
…mote freezer tx indices test a. The method was not implemented properly because the caller (the 'client') was not filling the argument values. b. The mock server was trying an impossible truncation on the maxBytes. This is a useless error because we dont actively support the freezer server implementation beyond the mock memory type. So I've just removed the maxBytes feature and it seems to work OK. Also the freezer doesn't expect compression, so we dont have to navigate that hefty logic like they do with the FreezerTable.RetrieveItems. Date: 2022-01-24 14:53:17-08:00 Signed-off-by: meows <[email protected]>
…ients This fixes a FIXME which left off this feature of the function. Date: 2022-01-25 15:58:11-08:00 Signed-off-by: meows <[email protected]>
|
@CodoGodo In review of this commit, can you say a little about what you're intention is here, and what you've done? The submodule commit looks fairly old, and I expect the testdata repo has later core-geth-relevant commits with, for example, the Mystique subtests. |
Closed
This condition appears to me to always be truthy, since the outer-scope msg From is compared to the inner-scoped sender value, which I expect to always be the case. This change does not appear to break any other tests. Date: 2022-02-28 12:33:45-08:00 Signed-off-by: meows <[email protected]>
Date: 2022-03-01 07:33:45-08:00 Signed-off-by: meows <[email protected]>
Resolved conflicts at findAncestorBinarySearch, which has been a buggy function for us before. Conflicts: eth/downloader/downloader.go
This is an attempt to fix this problem. Date: 2022-04-06 07:44:23-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-04-06 07:45:57-07:00 Signed-off-by: meows <[email protected]>
Issue exists upstream and has been reported, see skip reason for link. Date: 2022-04-06 09:46:17-07:00 Signed-off-by: meows <[email protected]>
- Using 'go get' for installs is deprecated, this uses 'go install' instead. - Set GOBIN env var so we know where the binary should go. Date: 2022-04-06 09:47:22-07:00 Signed-off-by: meows <[email protected]>
The '^1.17' syntax defines 1.17 as a floor, but quietly opts-in to later versions. Pegging to 1.17.8 (current latest 1.17 version) fixes a myriad of lint issues resulting from use with the latest 1.18 version. Date: 2022-04-06 10:01:27-07:00 Signed-off-by: meows <[email protected]>
|
The "myriad lint issues" I complain about in 36bae7a can be seen here: https://github.com/etclabscore/core-geth/runs/5854976278?check_suite_focus=true |
ziogaschr
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.