Add native stateDiff tracer #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame JS stateDiff tracer to legacy one
…or both JS and Native support
eth/tracers/native: add native stateDiffTracer (draft) core/vm,eth/tracers,eth/tracers/internal/tracetest: make it compile eth/tracers/internal/tracetest/testdata/state_diff: add some tests eth/tracers/internal/tracetest/testdata/state_diff,eth/tracers/native: stateDiff
this is useful for creating tests for stateDiff tracer
…h/tracers/js/internal/tracers,eth/tracers/js,eth/tracers/logger,eth/tracers/native: remove use of CapturePreEVM for JS legacy tracers
…r stateDiff tracer
…Dies on same call
…: stateDiff handle OOG on SELFDESTRUCT
ziogaschr
changed the title
meowsbits
reviewed
May 31, 2022
| // CaptureStart implements the EVMLogger interface to initialize the tracing operation. | ||
| func (t *prestateTracer) CaptureStart(env *vm.EVM, from common.Address, to common.Address, create bool, input []byte, gas uint64, value *big.Int) { | ||
| t.env = env | ||
| t.create = create | ||
| t.to = to | ||
|
|
||
| t.lookupAccount(t.env.Context.Coinbase) |
There was a problem hiding this comment.
So as it includes the miner's prestate for that block. Miner prestate is useful for creating stateDiff tests. We can remove this (comment out) and use it only when needed by me.
When I will create this PR to upstream geth, I am going to question this line.
meowsbits
approved these changes
May 31, 2022
|
LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
stateDifftracer from a JS tracer to a native Go tracer.