Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseFee on genesis block for dev.pow chain #471

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

ziogaschr
Copy link
Member

This fixes mining (panic), when --dev.pow flag is being used, by setting the BaseFee on the genesis block.

@ziogaschr ziogaschr requested a review from meowsbits May 10, 2022 22:22
@meowsbits
Copy link
Contributor

meowsbits commented May 11, 2022

Checked locally, fixes it for me.
Note that it will NOT work if you re-run on top of a failing database version from master; you need to remove and replace the datadir (or at least the genesis block entry).
The --dev.pow program runs by default with only an in-mem db, so this is an edge case.

@ziogaschr
Copy link
Member Author

Indeed, but because datadir has to be set to persist the DB and also that --dev.pow is a newer addition, I though of not trying to fix existing chains.
What do you think of that?

@ziogaschr ziogaschr merged commit f5d9e1f into master Jun 2, 2022
@ziogaschr ziogaschr deleted the fix/dev-pow-genesis-basefee branch June 2, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants